Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit a8872e6

Browse files
ShabbyXCommit Bot
authored andcommitted
Skip MSRTT tests on Nvidia/Windows7
These bots don't have VK_EXT_depth_stencil_resolve. Bug: chromium:1134286 Change-Id: I4cc5a627996139bf03dc3cc334435d08876a0a8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2443584 Reviewed-by: Shahbaz Youssefi <[email protected]> Commit-Queue: Shahbaz Youssefi <[email protected]>
1 parent 22d7db6 commit a8872e6

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

src/tests/gl_tests/MultisampledRenderToTextureTest.cpp

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1473,7 +1473,10 @@ TEST_P(MultisampledRenderToTextureES3Test, RenderbufferClearThenBlitDepthStencil
14731473
//
14741474
// - SwifthShader
14751475
// - Android
1476-
ANGLE_SKIP_TEST_IF(IsVulkan() && (isSwiftshader() || IsAndroid() || IsAMD()));
1476+
// - AMD
1477+
// - Nvidia on Windows7
1478+
ANGLE_SKIP_TEST_IF(IsVulkan() &&
1479+
(isSwiftshader() || IsAndroid() || IsAMD() || (IsWindows7() && IsNVIDIA())));
14771480

14781481
constexpr GLsizei kSize = 64;
14791482

@@ -1585,7 +1588,8 @@ TEST_P(MultisampledRenderToTextureES3Test, RenderbufferDrawThenBlitDepthStencil)
15851588

15861589
// Skip on configurations that don't support VK_KHR_depth_stencil_resolve. See comment
15871590
// in RenderbufferClearThenBlitDepthStencil.
1588-
ANGLE_SKIP_TEST_IF(IsVulkan() && (isSwiftshader() || IsAndroid() || IsAMD()));
1591+
ANGLE_SKIP_TEST_IF(IsVulkan() &&
1592+
(isSwiftshader() || IsAndroid() || IsAMD() || (IsWindows7() && IsNVIDIA())));
15891593

15901594
// http://anglebug.com/5096
15911595
ANGLE_SKIP_TEST_IF(IsLinux() && IsIntel() && IsVulkan());
@@ -1698,7 +1702,8 @@ TEST_P(MultisampledRenderToTextureES3Test, RenderbufferDrawThenBlitDepthStencilO
16981702

16991703
// Skip on configurations that don't support VK_KHR_depth_stencil_resolve. See comment
17001704
// in RenderbufferClearThenBlitDepthStencil.
1701-
ANGLE_SKIP_TEST_IF(IsVulkan() && (isSwiftshader() || IsAndroid() || IsAMD()));
1705+
ANGLE_SKIP_TEST_IF(IsVulkan() &&
1706+
(isSwiftshader() || IsAndroid() || IsAMD() || (IsWindows7() && IsNVIDIA())));
17021707

17031708
// http://anglebug.com/5096
17041709
ANGLE_SKIP_TEST_IF(IsLinux() && IsIntel() && IsVulkan());

src/tests/gl_tests/VulkanPerformanceCounterTest.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1645,6 +1645,9 @@ TEST_P(VulkanPerformanceCounterTest, RenderToTextureDepthStencilRenderbufferShou
16451645
// http://anglebug.com/5083
16461646
ANGLE_SKIP_TEST_IF(IsWindows() && IsAMD() && IsVulkan());
16471647

1648+
// http://crbug.com/1134286
1649+
ANGLE_SKIP_TEST_IF(IsWindows7() && IsNVIDIA() && IsVulkan());
1650+
16481651
ANGLE_SKIP_TEST_IF(!EnsureGLExtensionEnabled("GL_EXT_multisampled_render_to_texture"));
16491652

16501653
const rx::vk::PerfCounters &counters = hackANGLE();

0 commit comments

Comments
 (0)