Fix test_bottom_reference_shared.

At some point this test regressed so that it no longer tested the
behavior it purported to test.  The underlying behavior is correct;
the test just had to be fixed.

Change-Id: Ia54cb205b8f1a6062f4078009d24d865d70a6bac
Reviewed-on: https://dart-review.googlesource.com/74921
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Paul Berry <[email protected]>

Author: stereotype441

pkg/analyzer/test/src/summary/summarize_ast_one_phase_test.dart

@@ -16,12 +16,6 @@ main() {
 @reflectiveTest
 class SummarizeAstOnePhaseTest extends SummaryBlackBoxTestStrategyOnePhase
     with SummaryTestCases {
-  @override
-  @failingTest
-  test_bottom_reference_shared() {
-    super.test_bottom_reference_shared();
-  }
-
   @override
   @failingTest
   test_closure_executable_with_bottom_return_type() {

pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart

@@ -16,12 +16,6 @@ main() {
 @reflectiveTest
 class LinkedSummarizeAstStrongTest extends SummaryBlackBoxTestStrategyTwoPhase
     with SummaryTestCases {
-  @override
-  @failingTest
-  test_bottom_reference_shared() {
-    super.test_bottom_reference_shared();
-  }
-
   @override
   @failingTest
   test_closure_executable_with_imported_return_type() {

pkg/analyzer/test/src/summary/summary_common.dart

@@ -930,11 +930,13 @@ main() {
     }
     // The synthetic executables for both `x` and `y` have type `() => `Bottom`.
     // Verify that they both use the same reference to `Bottom`.
-    serializeLibraryText('int x = null; int y = null;');
+    serializeLibraryText('var x = throw null; var y = throw null;');
     EntityRef xInitializerReturnType =
         getTypeRefForSlot(findVariable('x').initializer.inferredReturnTypeSlot);
     EntityRef yInitializerReturnType =
         getTypeRefForSlot(findVariable('y').initializer.inferredReturnTypeSlot);
+    checkLinkedTypeRef(xInitializerReturnType, null, '*bottom*');
+    checkLinkedTypeRef(yInitializerReturnType, null, '*bottom*');
     expect(xInitializerReturnType.reference, yInitializerReturnType.reference);
   }