Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 7bc5c55

Browse files
stereotype441commit-bot@chromium.org
authored andcommitted
Fix test test_implicit_dependencies_follow_other_dependencies.
The test was assuming that summaries stored relative paths, which they haven't done for quite some time. Change-Id: Iee08f1e95650107886df85750e29aaf4267c60bb Reviewed-on: https://dart-review.googlesource.com/74920 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Paul Berry <[email protected]>
1 parent 49da026 commit 7bc5c55

File tree

3 files changed

+2
-14
lines changed

3 files changed

+2
-14
lines changed

pkg/analyzer/test/src/summary/summarize_ast_one_phase_test.dart

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,6 @@ class SummarizeAstOnePhaseTest extends SummaryBlackBoxTestStrategyOnePhase
4646
super.test_closure_executable_with_unimported_return_type();
4747
}
4848

49-
@override
50-
@failingTest
51-
test_implicit_dependencies_follow_other_dependencies() {
52-
super.test_implicit_dependencies_follow_other_dependencies();
53-
}
54-
5549
@override
5650
@failingTest
5751
test_inferred_type_refers_to_function_typed_param_of_typedef() {

pkg/analyzer/test/src/summary/summarize_ast_strong_test.dart

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,6 @@ class LinkedSummarizeAstStrongTest extends SummaryBlackBoxTestStrategyTwoPhase
4040
super.test_closure_executable_with_unimported_return_type();
4141
}
4242

43-
@override
44-
@failingTest
45-
test_implicit_dependencies_follow_other_dependencies() {
46-
super.test_implicit_dependencies_follow_other_dependencies();
47-
}
48-
4943
@override
5044
@failingTest
5145
test_inferred_type_refers_to_function_typed_param_of_typedef() {

pkg/analyzer/test/src/summary/summary_common.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7358,8 +7358,8 @@ get f => null;''';
73587358
// The dependency on b.dart is implicit, so it should be placed at the end
73597359
// of the dependency list, after a.dart, even though the code that refers
73607360
// to b.dart comes before the code that refers to a.dart.
7361-
int aDep = checkHasDependency('a.dart', fullyLinked: false);
7362-
int bDep = checkHasDependency('b.dart', fullyLinked: true);
7361+
int aDep = checkHasDependency(absUri('/a.dart'), fullyLinked: false);
7362+
int bDep = checkHasDependency(absUri('/b.dart'), fullyLinked: true);
73637363
expect(aDep, lessThan(bDep));
73647364
}
73657365

0 commit comments

Comments
 (0)