Let the flutter tool resolve engines on post-submit #4846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @jtmcdole. |
jtmcdole
reviewed
Aug 27, 2025
| @@ -875,10 +874,6 @@ class LuciBuildService { | |||
| processedProperties['is_fusion'] = 'true'; | |||
| if (commit.branch != Config.defaultBranch(Config.flutterSlug)) { | |||
| processedProperties.addAll({ | |||
| // For release candidates, let the flutter tool pick the right engine. | |||
There was a problem hiding this comment.
OH - This was "not master"; so did we do this to enable experimental branches as we don't have a merge queue? In which case, content hashing would solve this so long as they don't make engine builds...
There was a problem hiding this comment.
Hmm.
Experimental branches do make engine builds though. What should we do instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't sure why we are still doing this post content-aware hasing.