Add test exemption for engine code under testing/* #4033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The top-level `testing/` directory contains unit test support files. Most of these are test-specific OpenGL/Metal/Vulkan/Software context/surface code.
cbracken
requested review from
chinmaygarde,
jonahwilliams,
jtmcdole,
matanlurey and
stuartmorgan-g
and removed request for
jonahwilliams,
jtmcdole and
matanlurey
8 tasks
jtmcdole
reviewed
Nov 16, 2024
| filename.startsWith('${engineBasePath}impeller/playground') || | ||
| filename.startsWith('${engineBasePath}shell/platform/embedder/tests') || | ||
| filename.startsWith('${engineBasePath}shell/platform/embedder/fixtures') || | ||
| filename.startsWith('${engineBasePath}testing') || |
Member
There was a problem hiding this comment.
note to self: don't forget to set engineBasePath later.
jtmcdole
approved these changes
Nov 16, 2024
cbracken
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top-level
testing/directory contains unit test support files. Most of these are test-specific OpenGL/Metal/Vulkan/Software context/surface code.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.