This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Revert "[Darwin] Disable NSAsserts in release builds." #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5b504e1.
Member
Author
|
cc @bc-lee |
cbracken
approved these changes
May 31, 2024
jmagman
added
the
autosubmit
8 tasks
|
@jmagman are the fixes now in the engine? |
Member
Author
No, I forgot to file an issue about it, here it is flutter/flutter#157837. |
Member
|
Funny, I've had this tab open in a browser all week because I've been so tempted to give it another shot. @jmagman are you going to take a look? If no one gets around to it by the weekend, I'm kind of tempted to try to sneak it in with all the other cleanups. |
Member
Author
I wasn't planning on it, go for it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#860 isn't cleanly rolling into the engine due to side effects of turning off NSAsserts in release. Revert until the fixes are in the engine.