This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Fix OCMock static_library target #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #399, the static_library target was split into a source_set and static_library target, but this resulted in libocmock being built as an empty 88-byte library. We never caught the issue since this buildroot change was never rolled to the engine. This reverts things back to match how we build other static libraries such as libzip and libxml. This reverts 940dcf6.
xster
approved these changes
Sep 11, 2020
|
This will break my PR that depends on ocmock_src. See https://github.com/flutter/engine/pull/20531/files#diff-934b1a4a722f53c991b1f4445b307d3cR120 I needed a separate way to include ocmock for Mac and for iOS. I was prompted to write it this way after running into the errors I described here. CC @gaaclarke |
|
The way the buildroot change (#399) was written was resulting in an empty static_library with no symbols for (i.e. it was broken at head). I can take a look at relanding that so it generates a static_library with content. |
|
Alright thanks. I'm out of my usual area of expertise, but let me know if there's anything I can take a look at myself if it's not trivial for you. |
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
In flutter#399, the static_library target was split into a source_set and static_library target, but this resulted in libocmock being built as an empty 88-byte library. We never caught the issue since this buildroot change was never rolled to the engine. This reverts things back to match how we build other static libraries such as libzip and libxml. This reverts 940dcf6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #399, the static_library target was split into a
source_set and static_library target, but this resulted in libocmock
being built as an empty 88-byte library. We never caught the issue since
this buildroot change was never rolled to the engine.
This reverts things back to match how we build other static libraries
such as libzip and libxml.
This reverts 940dcf6.