Remove navigation key handling #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This is based on @swift-kim's report. |
Author
|
After #297 merged, I'll rebase to default branch and change this PR to ready state. |
* Navigation key event should be handled by the flutter framework. * Update related comments. * Fix incorrect type usage. Signed-off-by: Boram Bae <[email protected]>
bbrto21
force-pushed
the
remove_navigation_key_handling
branch
from
b436edf to
7803f8f
Compare
swift-kim
reviewed
Jun 29, 2022
Signed-off-by: Boram Bae <[email protected]>
bbrto21
force-pushed
the
remove_navigation_key_handling
branch
from
e2f6ce2 to
032cde9
Compare
swift-kim
approved these changes
Jun 30, 2022
Member
swift-kim
left a comment
swift-kim
left a comment
There was a problem hiding this comment.
Worked as expected on a TV emulator. Thanks!
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Navigation key event should be handled by the flutter framework. * Update related comments. * Fix incorrect type usage. Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Navigation key event should be handled by the flutter framework. * Update related comments. * Fix incorrect type usage. Signed-off-by: Boram Bae <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Boram Bae [email protected]