Fix key events propagation #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrto21
approved these changes
Jun 3, 2022
swift-kim
added a commit
that referenced
this pull request
Aug 5, 2022
swift-kim
added a commit
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following various fixes.
text_input_channel.cc(theelsestatement should come after#endif).TextInputChannel::SendKeyreturnfalseby default and check if the given key is actually handled byHandleKey. This fixes a problem of back button not responding when a TextField has a focus and a software keyboard is closed.PlatformViewChannel::SendKeytoboolto allow platform views to intercept key events without propagating to other handlers.Note:
TextInputChannel::HandleKeyhandles only key down events and thus some key up events (Left,Home, and etc.) are still redundantly propagated toPlatformViewChannelandKeyEventChannel.