Skip to content

Conversation

@bbrto21
Copy link

@bbrto21 bbrto21 commented May 20, 2022

  • Use only EVAS_GL_GLES_2_X on TizenRendererEvasGL.
    (All other platforms use only version 2 of the egl context client too.)

Signed-off-by: Boram Bae [email protected]

* Use only EVAS_GL_GLES_2_X on TizenRendererEvasGL.
 (All other platforms use only version 2 of the egl context client too.)

Signed-off-by: Boram Bae <[email protected]>
Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Member

@bwikbs bwikbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against this PR. (I think it's actually the simplest way.)
However, since there is a performance difference between versions, it seems necessary to consider whether flutter is really not using 3.0. (Although you already mentioned it...)

@bbrto21 bbrto21 merged commit 70fa036 into flutter-tizen:flutter-3.0.0-tizen May 23, 2022
swift-kim pushed a commit that referenced this pull request Aug 5, 2022
* Use only EVAS_GL_GLES_2_X on TizenRendererEvasGL.
 (All other platforms use only version 2 of the egl context client too.)

Signed-off-by: Boram Bae <[email protected]>
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
* Use only EVAS_GL_GLES_2_X on TizenRendererEvasGL.
 (All other platforms use only version 2 of the egl context client too.)

Signed-off-by: Boram Bae <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants