ActionResultExtensions are not working for Web API projects

[danielbecroft]

I'm not sure if it's something I'm doing, or a problem with a missing extension definition.

Our controller actions for an API project are defined as:

public async Task<ActionResult<IEnumerable<CustomerDto>>> Get()
{
    return Ok(await _mediator.Send(new GetCustomerQuery());
}

In the test:

var result = await sut.Get();

result.Should().BeOkObjectResult(); //

The code actually doesn't compile, as the Should() extension isn't detected properly. The extensions are defined as:

Should(this ActionResult actual);
Should(this IActionResult actual);

but the ActionResult is neither.

As a workaround, I've added an extension for Should(this IConvertToActionResult), and just call the .Convert() method.

Is there a better, or different approach here?

[kevinkuszyk]

@danielbecroft you should be able to just chain the Should() onto the result. Are you sure you have the latest nuget installed?

I also have to admit, I've not done much in the .net space recently.

@faddiv @SoftwareWizard can you offer any insight into this?

[faddiv]

Hello,
I will look into this.

[faddiv]

Ok, I figured it out. The fluentassertions.aspnetcore.mvc targets .net core 2.x versions and that generic ActionResult belongs to .net core 3.x api. This is not the only compatibility problem unfortunately. I could fix this issues but could you accept my last pull request beforehand @kevinkuszyk?

[kevinkuszyk]

Thanks @faddiv. Let's give @SoftwareWizard a couple more days to review #14 and then I'll merge it.

[kevinkuszyk]

@faddiv #14 is merged now. I'm going to hold off on pushing that to nuget until this issue is resolved.

If we need to bump to MVC Core 3.0 then that would be a breaking change which I'd ship as 3.0.

When you upgrade those dependencies can you pin them to the 3.0 releases so that we don't force consumers to take a point release before they are ready?

[faddiv]

I finished targeting the .net core 3.0, now I working on IConvertToActionResult assertions.
I'm a little unsure how this should look like so any input on this is welcome.
My idea looks like this:

result.Should()
  .BeActionResult<IEnumerable<CustomerDto>>()
  .???;

and/or something like this:

result.Should()
  .BeConvertibleTo<OkObjectResult>()
  .???;

You can check it in my repo: https://github.com/faddiv/fluentassertions.aspnetcore.mvc/tree/TargetNetcoreapp3_0

@SoftwareWizard I'm also interested in your opinion.