-
Notifications
You must be signed in to change notification settings - Fork 1.8k
logs_to_metrics: Support optional value_field for counters #10055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
68cd15e
to
e725188
Compare
e725188
to
2c1822f
Compare
Support incrementing counters by a specified value. If a `value_field` is specified for a counter, the counter is incremented by the given value instead of just counting the number of records. This allows tracking different metrics, such as the total number of bytes sent or received in an access log. Signed-off-by: Fabian Ruff <[email protected]>
2c1822f
to
db182ed
Compare
Valgrind output for unit tests:
|
This documents a feature added with this PR: fluent/fluent-bit#10055 Signed-off-by: Fabian Ruff <[email protected]>
@edsiper Kindly ping. At least the docs-required label can be removed |
@leonardo-albertovich kindly ping. Any chance to get a response |
@koleini @fujimotos Kindly ping. Any change that is is being looked at? It has tests, docs, all the things. I would love to see some progress on my PR. Thanks |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Support incrementing counters by a specified value
If a
value_field
is specified for a counter metric, the counter is incremented by the given value instead of just incrementing by 1.This allows counting more things then just the number of records, such as the total number of bytes sent or received from an access log.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
See docs PR for a configuration example: filter_logs_to_metrics: document field_value usage for counters fluent-bit-docs#1584
Documentation
Doc PR: fluent/fluent-bit-docs#1584
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.