Skip to content

Conversation

daquinteroflex
Copy link
Collaborator

@daquinteroflex daquinteroflex commented Aug 25, 2025

Reverts #2756

Greptile Summary

This pull request reverts PR #2756, which had attempted to standardize batch web status names from mixed PascalCase/CamelCase format to snake_case format across the RF/component modeler API. The reversion affects three core files in the web API system:

Key Changes Made:

  • BatchStatus enum: Reverts status values from snake_case back to mixed format (e.g., 'validate_success' → 'Validate_Success', 'run_failed' → 'Run_Failed')
  • Status checking logic: Updates all status validation and monitoring code in task_core.py and webapi.py to use the original PascalCase/mixed format
  • API consistency: Ensures client-side status checking matches the format returned by backend services

The changes span critical batch processing functionality including validation workflows (wait_for_validate()), execution monitoring (wait_for_run()), error detection, and postprocessing triggers. The reversion restores the original mixed naming convention where some statuses use PascalCase ('Created', 'Running') while others use underscore-separated format ('Validate_Success', 'Run_Failed').

This revert indicates that the backend RF/component modeler API was not updated to match the snake_case standardization, creating a mismatch between client expectations and server responses. The batch processing system requires exact string matching for status transitions, making this alignment critical for proper workflow execution.

Important Files Changed

Files Changed
Filename Score Overview
tidy3d/web/core/task_info.py 2/5 Reverts BatchStatus enum from snake_case to mixed PascalCase/underscore format, potentially breaking if backend expects snake_case
tidy3d/web/core/task_core.py 4/5 Reverts status checking logic in validation and execution monitoring to match backend API format
tidy3d/web/api/webapi.py 4/5 Systematically updates status validation, error detection, and monitoring logic back to PascalCase format

Confidence score: 3/5

  • This revert appears necessary to fix compatibility issues with backend API that still returns PascalCase status values
  • Score reflects uncertainty about backend API state and potential for breaking changes if revert is incomplete
  • Pay close attention to tidy3d/web/core/task_info.py where enum changes could cause runtime errors if backend format differs

@daquinteroflex daquinteroflex marked this pull request as ready for review August 25, 2025 10:19
@daquinteroflex daquinteroflex merged commit f3b72f6 into dario/rf_endpoints_update Aug 25, 2025
@daquinteroflex daquinteroflex deleted the revert-2756-dario/rf_web_status_updates branch August 25, 2025 10:19
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

daquinteroflex added a commit that referenced this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant