Add Python build to MSVC CI #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: See title. Fixed by adding `-DCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON` to the Windows build which actually exported everything without having to change the source, hooray Enables building Flashlight Text wheels on Windows Pull Request resolved: #16 Test Plan: CI Differential Revision: D39760655 Pulled By: jacobkahn fbshipit-source-id: 8a1fab0c0e50f7c4717c3d10308af6171103e27d
jacobkahn
force-pushed
the
windows_ci
branch
from
01a41ce to
942a80f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39760655 |
|
Just wanted to point you to this PR from @mthrok pytorch/text#1806 which only exports relevant symbols on Windows platform. The reasoning being
This may not be relevant here as it's unlikely you'd be hitting the upper bound in your library, but thought it might be worth calling out. |
Member
Author
|
@Nayef211 thanks for that callout -- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See title. Fixed by adding
-DCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ONto the Windows build which actually exported everything without having to change the source, hoorayEnables building Flashlight Text wheels on Windows
Test plan: CI