fix: ping/pong upstream server #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
SozinM
reviewed
Jun 30, 2025
SozinM
reviewed
Jun 30, 2025
SozinM
reviewed
Jun 30, 2025
SozinM
reviewed
Jun 30, 2025
|
looks good IMO |
SozinM
approved these changes
Jul 1, 2025
danyalprout
force-pushed
the
ping-pong-upstream
branch
from
4e9fde9 to
6f51e27
Compare
danyalprout
force-pushed
the
ping-pong-upstream
branch
from
6f51e27 to
c446a1b
Compare
|
@SozinM can I get a review on this when you have time -- thanks |
SozinM
reviewed
Jul 31, 2025
| let mut interval = tokio::time::interval(options.ping_interval); | ||
| loop { | ||
| interval.tick().await; | ||
| if let Err(e) = write.send(Message::Ping(bytes::Bytes::new())).await { |
There was a problem hiding this comment.
Should this be random bytes?
There was a problem hiding this comment.
it doesn't really matter, it can be empty and won't matter. as long as a Ping is going, a Pong is expected. contents of ping is kind of useless imo
There was a problem hiding this comment.
Yeah, it being empty should be ok. The mean reason to add data is to be able to track ping/pongs that are sent/arrive out of order.
Happy to add a couple of bytes of randomness if ya'll feel strongly about it
SozinM
approved these changes
Jul 31, 2025
|
merging is as it's on;y websocket proxy changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ping/pong for upstream connections (see #322). I'll add the equivalent for downstream clients in a separate PR