Add dont_touches + Basic Floorplan for DRAM controllers #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbiancolin
force-pushed
the
clock-partitioning
branch
from
19d3e2c to
cb2cc9b
Compare
11 tasks
There was a problem hiding this comment.
This mostly looks fine, I'd just like to clarify why the tck to real clocks aren't being made into async clock groups anymore. The commented out contstraints are maybe something we could clean up before adding them into the repo but I'll leave that to you to decide.
Comment on lines
-3
to
-6
| # False paths between main clock and tck | ||
| set_clock_groups -name TIG_SRAI_1 -asynchronous -group [get_clocks -of_objects [get_pins static_sh/SH_DEBUG_BRIDGE/inst/bsip/inst/USE_SOFTBSCAN.U_TAP_TCKBUFG/O]] -group [get_clocks -of_objects [get_pins SH/kernel_clks_i/clkwiz_sys_clk/inst/CLK_CORE_DRP_I/clk_inst/mmcme3_adv_inst/CLKOUT0]] | ||
| set_clock_groups -name TIG_SRAI_2 -asynchronous -group [get_clocks -of_objects [get_pins static_sh/SH_DEBUG_BRIDGE/inst/bsip/inst/USE_SOFTBSCAN.U_TAP_TCKBUFG/O]] -group [get_clocks drck] | ||
| set_clock_groups -name TIG_SRAI_3 -asynchronous -group [get_clocks -of_objects [get_pins static_sh/SH_DEBUG_BRIDGE/inst/bsip/inst/USE_SOFTBSCAN.U_TAP_TCKBUFG/O]] -group [get_clocks -of_objects [get_pins static_sh/pcie_inst/inst/gt_top_i/diablo_gt.diablo_gt_phy_wrapper/phy_clk_i/bufg_gt_userclk/O]] |
There was a problem hiding this comment.
@davidbiancolin are these being removed intentionally? If so, could you explain why they aren't needed?
There was a problem hiding this comment.
David is following up with AWS in https://forums.aws.amazon.com/thread.jspa?threadID=342848&tstart=0
There was a problem hiding this comment.
AWS has confirmed we can remove this (see the forum post above).
timsnyder-siv
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
I pulled in the floorplan from cl_dram_dma, and just kept the pblock constraints for nodes that are common across that example design and our design. I think we could consider pulling in some of the DRAM crossbar, but i'll leave that to a later PR.