Skip to content

[EXC-782] - Added Types #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[EXC-782] - Added Types #65

wants to merge 2 commits into from

Conversation

YameenMalik
Copy link
Contributor

@YameenMalik YameenMalik commented Apr 8, 2023 •
edited
Loading

  • Added return type to methods
  • Added types to function params

TODO:

  • Create interfaces for data returned by get routes and update return type to all get route calls in client.py [EXEC-868]

@YameenMalik YameenMalik changed the title Types Added Types Apr 8, 2023
@YameenMalik YameenMalik self-assigned this Apr 8, 2023
@YameenMalik YameenMalik changed the title Added Types [EXC-782] - Added Types Apr 8, 2023
@YameenMalik YameenMalik marked this pull request as draft April 26, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malikkulsoom malikkulsoom malikkulsoom approved these changes

@MaazUddin11 MaazUddin11 Awaiting requested review from MaazUddin11

@shahzaib-sheikh shahzaib-sheikh Awaiting requested review from shahzaib-sheikh

Assignees

@YameenMalik YameenMalik

Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YameenMalik @malikkulsoom