Skip to content

Irksome smoke tests #4386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: release
Choose a base branch
from
Draft

Irksome smoke tests #4386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,19 @@ jobs:
timeout-minutes: 15


- name: Run Irksome smoke tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason you've put these before the standard tests, rather than with the other smoke tests?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does help with debugging as you don't need to wait for the whole test suite to run to find out if you messed up.

# Only test Irksome in real mode
if: |
inputs.run_tests &&
(success() || steps.install.conclusion == 'success') &&
matrix.arch == 'default'
run: |
. venv/bin/activate
git clone --depth 1 https://github.com/firedrakeproject/irksome.git irksome-repo
pip install --verbose ./irksome-repo
python -m pytest -n 8 --verbose irksome-repo/tests
timeout-minutes: 10

- name: Run Firedrake tests (nprocs = 1)
if: inputs.run_tests && (success() || steps.install.conclusion == 'success')
run: |
Expand Down
Loading