Add Firestore bundles snippets #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-hui
reviewed
Mar 12, 2021
| bundleStream.close(); | ||
|
|
||
| // Calling getResult() propagates errors | ||
| LoadBundleTaskProgress progress = task.getResult(); |
There was a problem hiding this comment.
Hmm, what happens if we don't have this?
|
Also adding @schmidt-sebastian for another look |
wu-hui
approved these changes
Mar 12, 2021
thatfiredev
reviewed
Mar 12, 2021
firestore/app/src/main/java/com/google/example/firestore/kotlin/SolutionBundles.kt
Outdated
Show resolved
Hide resolved
…n/SolutionBundles.kt Co-authored-by: Rosário Pereira Fernandes <[email protected]>
schmidt-sebastian
approved these changes
Mar 12, 2021
| @Override | ||
| public Task<Query> then(@NonNull Task<LoadBundleTaskProgress> task) throws Exception { | ||
| // Close the stream | ||
| bundleStream.close(); |
There was a problem hiding this comment.
Sam - do you think the SDK should close the stream? I am not sure what the expected behavior is.
Contributor
Author
There was a problem hiding this comment.
I was wondering the same thing ... I personally would like that but I really don't do enough Java I/O programming to have an informed opinion.
thatfiredev
reviewed
Mar 12, 2021
| return connection.getInputStream(); | ||
| } | ||
|
|
||
| public void fetchBunldeFrom() throws IOException { |
Member
There was a problem hiding this comment.
Typo 😁
Suggested change
| public void fetchBunldeFrom() throws IOException { | |
| public void fetchBundleFrom() throws IOException { |
vkryachko
reviewed
Mar 12, 2021
| fun getBundleStream(urlString: String?): InputStream { | ||
| val url = URL(urlString) | ||
| val connection = url.openConnection() as HttpURLConnection | ||
| return connection.inputStream |
Member
There was a problem hiding this comment.
Does firestore buffer the stream internally? otherwise it may be very inefficient to read from an unbuffered stream
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android snippets for:
https://firebase.google.com/docs/firestore/solutions/serve-bundles