Skip to content

Optimize CloudLandmarkGraphic #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2018
Merged

Optimize CloudLandmarkGraphic #697

merged 3 commits into from
Oct 17, 2018

Conversation

@XinyueZ
Copy link
Contributor

@XinyueZ XinyueZ commented Oct 6, 2018 •
edited
Loading

  • Remove init{} for variable initialization, use apply() directly.
  • Remove meanless lateinit of landmark. Define it as nullable is more meaningful, when it is really null, then send exception.

@XinyueZ XinyueZ force-pushed the optimize/CloudLandmarkGraphic branch from 5d80e6f to 6b74eb9 Compare October 6, 2018 22:52
@samtstern
Copy link
Contributor

@XinyueZ sorry I missed this! Could you resolve the conflicts?

@XinyueZ
Copy link
Contributor Author

XinyueZ commented Oct 17, 2018

@samtstern conflicts resolved.

@samtstern
Copy link
Contributor

Build passed, thanks!

@samtstern samtstern merged commit 422cbf6 into firebase:master Oct 17, 2018
@snyk-bot snyk-bot mentioned this pull request Jul 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XinyueZ @samtstern