Convert database quickstart to Kotlin #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatfiredev
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/MainActivity.kt
Outdated
Show resolved
Hide resolved
thatfiredev
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/NewPostActivity.kt
Outdated
Show resolved
Hide resolved
thatfiredev
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/NewPostActivity.kt
Outdated
Show resolved
Hide resolved
thatfiredev
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/PostDetailActivity.kt
Outdated
Show resolved
Hide resolved
thatfiredev
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/PostDetailActivity.kt
Outdated
Show resolved
Hide resolved
thatfiredev
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/PostDetailActivity.kt
Show resolved
Hide resolved
thatfiredev
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/PostDetailActivity.kt
Outdated
Show resolved
Hide resolved
thatfiredev
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/PostDetailActivity.kt
Outdated
Show resolved
Hide resolved
thatfiredev
reviewed
Sep 11, 2018
...pp/src/main/java/com/google/firebase/quickstart/database/kotlin/fragment/PostListFragment.kt
Outdated
Show resolved
Hide resolved
thatfiredev
reviewed
Sep 11, 2018
...pp/src/main/java/com/google/firebase/quickstart/database/kotlin/fragment/PostListFragment.kt
Outdated
Show resolved
Hide resolved
thatfiredev
reviewed
Sep 11, 2018
...src/main/java/com/google/firebase/quickstart/database/kotlin/fragment/RecentPostsFragment.kt
Outdated
Show resolved
Hide resolved
thatfiredev
reviewed
Sep 11, 2018
the-dagger
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/MainActivity.kt
Outdated
Show resolved
Hide resolved
the-dagger
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/NewPostActivity.kt
Outdated
Show resolved
Hide resolved
the-dagger
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/NewPostActivity.kt
Outdated
Show resolved
Hide resolved
the-dagger
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/NewPostActivity.kt
Outdated
Show resolved
Hide resolved
the-dagger
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/NewPostActivity.kt
Outdated
Show resolved
Hide resolved
the-dagger
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/PostDetailActivity.kt
Outdated
Show resolved
Hide resolved
the-dagger
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/PostDetailActivity.kt
Outdated
Show resolved
Hide resolved
the-dagger
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/PostDetailActivity.kt
Outdated
Show resolved
Hide resolved
the-dagger
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/SignInActivity.kt
Outdated
Show resolved
Hide resolved
the-dagger
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/SignInActivity.kt
Show resolved
Hide resolved
the-dagger
reviewed
Sep 11, 2018
database/app/src/main/java/com/google/firebase/quickstart/database/kotlin/SignInActivity.kt
Outdated
Show resolved
Hide resolved
the-dagger
reviewed
Sep 11, 2018
...pp/src/main/java/com/google/firebase/quickstart/database/kotlin/fragment/PostListFragment.kt
Show resolved
Hide resolved
the-dagger
reviewed
Sep 11, 2018
the-dagger
reviewed
Sep 11, 2018
...pp/src/main/java/com/google/firebase/quickstart/database/kotlin/fragment/PostListFragment.kt
Outdated
Show resolved
Hide resolved
the-dagger
approved these changes
Sep 11, 2018
Change-Id: Ifcb9ce439a1c3e383e11f75b3c5e159af1e5c6b8
Change-Id: I0f9de2781911366c29045fa1a312e97e019d5632
Change-Id: Iec50975804fd214827c63f36a0e617bf0509f64d
Change-Id: I9ac66f5c5f1bfe085b76e570a5c26c0d5dc785b0
Change-Id: Ic4b4315a504784432ffbf244e3086fe3c7b92590
samtstern
force-pushed
the
ss-database-kotlin
branch
from
d8c66b4 to
f1cfcde
Compare
|
@the-dagger hey the lint check found some errors in this PR (after I rebased) so, success! |
Change-Id: Ifcd9fda9e72eb9634b5c619f08b8fdf06274cb26
|
Woot! 💯 I've used it earlier and it's super helpful for monitoring common mistakes in pull requests. |
|
I've got to check the permissions on codacy, in general I like checks like
that but sometimes they require access to see the whole org. We have some
private repos.
…On Tue, Sep 11, 2018, 4:49 PM Harshit Dwivedi ***@***.***> wrote:
Woot! 💯
I too noticed some super helpful errors while converting the app-indexing
quickstarters.
I think that we should add more lint checks, also what do you think about
adding Codacy to the project?
https://www.codacy.com/
I've used it earlier and it's super helpful for monitoring common mistakes
in pull requests.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#654 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIEw6qTDu9zZ8mydME2QEVrXYGPbg9WDks5uaEwAgaJpZM4WiTw3>
.
|
|
Ah I see. |
|
@the-dagger yeah they use the broad permissions: I'm sure they never would, but granting read and write access means they could nuke all of our samples and snippets! So for now, no Codacy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #628
This was a pretty big one!