Skip to content

feat : kotlinize crash quickstart #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2018
Merged

feat : kotlinize crash quickstart #647

merged 2 commits into from
Sep 10, 2018

Conversation

@the-dagger
Copy link
Contributor

fix #627

samtstern
samtstern approved these changes Sep 8, 2018
View reviewed changes
Copy link
Contributor

@samtstern samtstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one tiny comment.

@samtstern samtstern merged commit 1d7459b into firebase:master Sep 10, 2018
@the-dagger the-dagger deleted the kotlin_crash branch September 10, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thatfiredev thatfiredev thatfiredev approved these changes

+1 more reviewer

@samtstern samtstern samtstern approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Internal] Translate crash app to kotlin

4 participants

@the-dagger @samtstern @thatfiredev @harshithdwivedi