Convert firestore quickstart to Kotlin #638

samtstern · 2018-09-06T22:43:33Z

Fixes #630

Change-Id: I3995228bb5b924cf3d63a1906dd8b461088759c0

Change-Id: Ieeeebb59750672b9126f9d039a8736341a640492

Change-Id: I1e7a8d63b8b65fbbcefaaddc11c8b8008bfc55af

Change-Id: I0f71b80b14306b9a790b3663b23e3bdb4c63f8ac

samtstern · 2018-09-07T19:09:52Z

@the-dagger @rosariopfernandes if either one of you has time to review, this one is ready to go.

If not I can get someone on my team to review, don't need to take up all of your time!

Change-Id: Id4fcd606fbe8b529fb6c2c2c9acd4b1f42c92111

thatfiredev · 2018-09-07T19:17:43Z

@samtstern Sure, I'll have a look.

firestore/app/src/main/java/com/google/firebase/example/fireeats/java/FilterDialogFragment.java

the-dagger · 2018-09-07T19:26:36Z

firestore/app/src/main/java/com/google/firebase/example/fireeats/kotlin/FilterDialogFragment.kt

+    }
+
+    fun onSearchClicked() {
+        if (filterListener != null) {


I think that this can be replaced with a safe call. ?.

I believe this would do:

filterListener?.let{ filterListener.onFilter(filters) }

Yep, correct.
Also, I think that

filterListener?.onFilter(filters)

would work just fine as well, no need for the let block.

What do you think @rosariopfernandes?

PERFECTION ✨

the-dagger · 2018-09-07T19:29:24Z

firestore/app/src/main/java/com/google/firebase/example/fireeats/kotlin/MainActivity.kt

+
+        // Sort by (orderBy with direction)
+        if (filters.hasSortBy()) {
+            query = query.orderBy(filters.sortBy!!, filters.sortDirection!!)


Instead of !! can we use toString() on these params?

the-dagger · 2018-09-07T19:32:14Z

firestore/app/src/main/java/com/google/firebase/example/fireeats/kotlin/RatingDialogFragment.kt

+
+    override fun onResume() {
+        super.onResume()
+        dialog.window!!.setLayout(


Personally, I think that we should avoid the not-null assertion operator (!!) as much as we can.
Leads to undesirable NPEs!

https://kotlinlang.org/docs/reference/null-safety.html

the-dagger · 2018-09-07T19:32:41Z

firestore/app/src/main/java/com/google/firebase/example/fireeats/kotlin/RatingDialogFragment.kt

+                restaurantFormRating.rating.toDouble(),
+                restaurantFormText.text.toString())
+
+        if (ratingListener != null) {


Same, can be replaced with a safe call operator ?.

firestore/app/src/main/java/com/google/firebase/example/fireeats/kotlin/FilterDialogFragment.kt

the-dagger · 2018-09-07T19:34:38Z

firestore/app/src/main/java/com/google/firebase/example/fireeats/kotlin/model/Rating.kt

+/**
+ * Model POJO for a rating.
+ */
+class Rating {


Can we use a data class here?

the-dagger · 2018-09-07T19:34:50Z

firestore/app/src/main/java/com/google/firebase/example/fireeats/kotlin/model/Restaurant.kt

+ * Restaurant POJO.
+ */
+@IgnoreExtraProperties
+class Restaurant {


Data class here as well

the-dagger

@samtstern added some pointers.
Most of it looks good!

Change-Id: I063d6190ca8136a83249b37c48e2d643df74067e

firestore/app/build.gradle

Change-Id: I08a033f6a890efca393da5faa073ba1495273af5

Change-Id: I1c97a006b23e32f5b35a7e8640b83c42b98a323a

samtstern added 4 commits September 6, 2018 15:42

Move everything to a Java subpackage

80fb6a4

Change-Id: I3995228bb5b924cf3d63a1906dd8b461088759c0

Minium viable Kotlin

2489f35

Change-Id: Ieeeebb59750672b9126f9d039a8736341a640492

No more butterknife

56dbef5

Change-Id: I1e7a8d63b8b65fbbcefaaddc11c8b8008bfc55af

Remove hungarian notation and nullability, where possible

f869b5a

Change-Id: I0f71b80b14306b9a790b3663b23e3bdb4c63f8ac

samtstern changed the title ~~[WIP] Convert firestore quickstart to Kotlin~~ Convert firestore quickstart to Kotlin Sep 7, 2018

Fix lint

4fe8919

Change-Id: Id4fcd606fbe8b529fb6c2c2c9acd4b1f42c92111

the-dagger reviewed Sep 7, 2018

View reviewed changes

firestore/app/src/main/java/com/google/firebase/example/fireeats/java/FilterDialogFragment.java Show resolved Hide resolved

the-dagger reviewed Sep 7, 2018

View reviewed changes

thatfiredev approved these changes Sep 7, 2018

View reviewed changes

firestore/app/src/main/java/com/google/firebase/example/fireeats/kotlin/FilterDialogFragment.kt Outdated Show resolved Hide resolved

the-dagger reviewed Sep 7, 2018

View reviewed changes

Review feedback

ea927b1

Change-Id: I063d6190ca8136a83249b37c48e2d643df74067e

the-dagger approved these changes Sep 7, 2018

View reviewed changes

the-dagger reviewed Sep 7, 2018

View reviewed changes

firestore/app/build.gradle Show resolved Hide resolved

samtstern added 2 commits September 7, 2018 13:00

Improve null safety

d8229ec

Change-Id: I08a033f6a890efca393da5faa073ba1495273af5

Final review nits

1b54086

Change-Id: I1c97a006b23e32f5b35a7e8640b83c42b98a323a

thatfiredev approved these changes Sep 7, 2018

View reviewed changes

samtstern merged commit e1e8816 into master Sep 7, 2018

samtstern deleted the ss-firestore-kotlin branch September 10, 2018 21:11

This was referenced May 29, 2020

[Snyk] Security upgrade firebase-functions from 0.9.0 to 3.6.2 WittmannJ/quickstart-android#5

Open

[Snyk] Security upgrade firebase-functions from 0.9.0 to 3.6.2 Jeremip11/quickstart-android#4

Open

This was referenced Oct 5, 2022

[Snyk] Fix for 13 vulnerabilities lsdace30095/quickstart-android#8

Open

[Snyk] Fix for 13 vulnerabilities lsdace30095/quickstart-android#9

Open

[Snyk] Fix for 13 vulnerabilities lsdace30095/quickstart-android#10

Open

lsdace30095 mentioned this pull request Oct 9, 2022

[Snyk] Fix for 13 vulnerabilities lsdace30095/quickstart-android#11

Open

lsdace30095 mentioned this pull request Dec 22, 2022

[Snyk] Security upgrade firebase-functions from 0.9.0 to 3.6.2 lsdace30095/quickstart-android#12

Open

WittmannJ mentioned this pull request Dec 22, 2022

[Snyk] Security upgrade firebase-functions from 0.9.0 to 3.6.2 WittmannJ/quickstart-android#12

Open

Jeremip11 mentioned this pull request Dec 23, 2022

[Snyk] Fix for 4 vulnerabilities Jeremip11/quickstart-android#11

Open

lsdace30095 mentioned this pull request Dec 23, 2022

[Snyk] Fix for 4 vulnerabilities lsdace30095/quickstart-android#13

Open

snyk-bot mentioned this pull request Dec 23, 2022

[Snyk] Fix for 4 vulnerabilities KatanMichael/quickstart-android#7

Open

Convert firestore quickstart to Kotlin #638

Convert firestore quickstart to Kotlin #638

Uh oh!

Conversation

samtstern commented Sep 6, 2018

Uh oh!

samtstern commented Sep 7, 2018

Uh oh!

thatfiredev commented Sep 7, 2018

Uh oh!

Uh oh!

the-dagger Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thatfiredev Sep 7, 2018

Choose a reason for hiding this comment

Uh oh!

the-dagger Sep 7, 2018

Choose a reason for hiding this comment

Uh oh!

thatfiredev Sep 7, 2018

Choose a reason for hiding this comment

Uh oh!

the-dagger Sep 7, 2018

Choose a reason for hiding this comment

Uh oh!

the-dagger Sep 7, 2018

Choose a reason for hiding this comment

Uh oh!

the-dagger Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

the-dagger Sep 7, 2018

Choose a reason for hiding this comment

Uh oh!

the-dagger Sep 7, 2018

Choose a reason for hiding this comment

Uh oh!

the-dagger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

the-dagger Sep 7, 2018 •

edited

Loading

the-dagger Sep 7, 2018 •

edited

Loading