Compose code for App Distribution #1630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@b1no0019 thanks for fixing the CLA :) |
thatfiredev
requested review from
thatfiredev and
ulukaya
and removed request for
ulukaya
thatfiredev
reviewed
May 31, 2024
Comment on lines
18
to
33
| /* Other default text styles to override | ||
| titleLarge = TextStyle( | ||
| fontFamily = FontFamily.Default, | ||
| fontWeight = FontWeight.Normal, | ||
| fontSize = 22.sp, | ||
| lineHeight = 28.sp, | ||
| letterSpacing = 0.sp | ||
| ), | ||
| labelSmall = TextStyle( | ||
| fontFamily = FontFamily.Default, | ||
| fontWeight = FontWeight.Medium, | ||
| fontSize = 11.sp, | ||
| lineHeight = 16.sp, | ||
| letterSpacing = 0.5.sp | ||
| ) | ||
| */ |
There was a problem hiding this comment.
I understand this comment is created by Android Studio, but I think we can remove it since we won't be overriding any more styles.
Suggested change
| /* Other default text styles to override | |
| titleLarge = TextStyle( | |
| fontFamily = FontFamily.Default, | |
| fontWeight = FontWeight.Normal, | |
| fontSize = 22.sp, | |
| lineHeight = 28.sp, | |
| letterSpacing = 0.sp | |
| ), | |
| labelSmall = TextStyle( | |
| fontFamily = FontFamily.Default, | |
| fontWeight = FontWeight.Medium, | |
| fontSize = 11.sp, | |
| lineHeight = 16.sp, | |
| letterSpacing = 0.5.sp | |
| ) | |
| */ |
Comment on lines
20
to
29
|
|
||
| /* Other default colors to override | ||
| background = Color(0xFFFFFBFE), | ||
| surface = Color(0xFFFFFBFE), | ||
| onPrimary = Color.White, | ||
| onSecondary = Color.White, | ||
| onTertiary = Color.White, | ||
| onBackground = Color(0xFF1C1B1F), | ||
| onSurface = Color(0xFF1C1B1F), | ||
| */ |
There was a problem hiding this comment.
I understand this comment was added by Android Studio, but I think we can remove it.
Suggested change
| /* Other default colors to override | |
| background = Color(0xFFFFFBFE), | |
| surface = Color(0xFFFFFBFE), | |
| onPrimary = Color.White, | |
| onSecondary = Color.White, | |
| onTertiary = Color.White, | |
| onBackground = Color(0xFF1C1B1F), | |
| onSurface = Color(0xFF1C1B1F), | |
| */ |
| Spacer(modifier = Modifier.height(30.dp)) | ||
| Image( | ||
| painterResource(R.drawable.firebase_lockup_400), | ||
| contentDescription = "", |
There was a problem hiding this comment.
Can we add a content description to this image?
Suggested change
| contentDescription = "", | |
| contentDescription = "Firebase logo", |
|
|
||
| // Used to inject this ViewModel's dependencies | ||
| // See also: https://developer.android.com/topic/libraries/architecture/viewmodel/viewmodel-factories | ||
|
|
There was a problem hiding this comment.
nit: remove empty line
Suggested change
|
Thanks for the review @thatfiredev. All suggestions were applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EntryChoiceActivityComposeMainActivityAppDistributionViewModelComposeMainActivityinAndroidManifest