Compose Firebase Dynamic Links #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added DynamicLinksViewModel for business logic - Added MainComposeActivity for the jetpack compose UI
|
@argzdev I'll take a closer look at these, but in the meantime I noticed that CI is failing due to snippets errors (the |
|
Got it, I'll remove those snippets. Thanks for taking a look into it, @thatfiredev! |
|
In the |
…rate Preview of the content.
thatfiredev
reviewed
May 22, 2023
...s/app/src/main/java/com/google/firebase/quickstart/deeplinks/kotlin/DynamicLinksViewModel.kt
Outdated
Show resolved
Hide resolved
...s/app/src/main/java/com/google/firebase/quickstart/deeplinks/kotlin/DynamicLinksViewModel.kt
Outdated
Show resolved
Hide resolved
...nks/app/src/main/java/com/google/firebase/quickstart/deeplinks/kotlin/MainComposeActivity.kt
Outdated
Show resolved
Hide resolved
...nks/app/src/main/java/com/google/firebase/quickstart/deeplinks/kotlin/MainComposeActivity.kt
Outdated
Show resolved
Hide resolved
…parent directory path. - Converted methods `buildShortLinkFromParams` and `buildDeepLink` to use coroutines - Added Column to use paddingValues of `it`
- Removed @VisibleForTesting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For review by Rosário Fernandes
EntryChoiceActivityMainActivityDynamicLinksViewModelfor business logicMainComposeActivityfor the Jetpack Compose UI