[Internal] Create a lint to make sure java classes are not imported from kotlin classes

[samtstern]

When converting to kotlin it's very easy to get crossed imports.

If we see a package foo.kotlin, none of the code in there should import from foo.java

[the-dagger]

@samstern how are you planning on implementing this?
As some sort of style check or baked into the default lint check?

Also any good resources that you might link to read up on creating a custom lint checker?

[samtstern]

I think this could be implemented inside the internal module and exported as lintChecks.

I have only done a custom lint check one time, and that's in FirebaseUI-Android. I may try to copy from that, but I don't actually know if that's the easiest way.

But anyway yeah I can tackle this one, unless you really want to do it just for learning purposes.

[the-dagger]

I wanted to explore this as I've not done something like this before.
Can you share the relevant code you did in FirebaseUI?
I can use that as reference and try to fix this one by myself and if things hit the fan you can take over.

How does that sound?

[samtstern]

Sgtm! Here's an example lint check in FBUI: https://github.com/firebase/FirebaseUI-Android/blob/master/internal/lint/src/main/java/com/firebaseui/lint/FirestoreRecyclerAdapterLifecycleDetector.kt There are others in that folder as well. We did some really strange packaging tricks to be able to hide our lints from library users but you won't have to do any of that.

…

On Fri, Sep 7, 2018, 4:57 PM Harshit Dwivedi ***@***.***> wrote: I wanted to explore this as I've not done something like this before. Can you share the relevant code you did in FirebaseUI? I can use that as reference and try to fix this one by myself and if things hit the fan you can take over. How does that sound? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#643 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIEw6lFhth1znvolyH8DKvElaMZOdjeOks5uYwfLgaJpZM4WffG6> .