Skip to content

breaking(go): Refactored primitives APIs to be consistent #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Aug 19, 2025

Conversation

apascal07
Copy link
Collaborator

@apascal07 apascal07 commented Aug 12, 2025

Lots of different changes here, mostly summarized by:

  • All "developer path" code now panics instead of returning errors, this includes genkit.Init() and all Define*() functions. This allows to define primitives statically and allow for cleaner code. "User path" code returns errors to be handled and/or retried.
  • Changed usage of jsonschema.Schema to map[string]any to be package agnostic.
  • All Define*() now accept custom configs which are validated against the custom schema provided at definition.
  • All primitives now have a veneer that accepts a reference of that type which may include an optional config.

Checklist (if applicable):

@apascal07 apascal07 requested a review from hugoaguirre August 13, 2025 14:32
@apascal07 apascal07 requested a review from pavelgj August 13, 2025 17:18
@apascal07 apascal07 marked this pull request as ready for review August 13, 2025 17:18
@apascal07 apascal07 enabled auto-merge (squash) August 19, 2025 18:08
@apascal07 apascal07 merged commit e776111 into main Aug 19, 2025
7 checks passed
@apascal07 apascal07 deleted the ap/go-primitives-refactor branch August 19, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants