Skip to content

fix(web): indirect dart:js_interop conditional import to fix dart2js build issue #12925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2024
Merged

fix(web): indirect dart:js_interop conditional import to fix dart2js build issue #12925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eee57cb
fix(web): indirect dart:js_interop conditional import to fix dart2js …
elitree May 31, 2024
d4503ea
Update js_interop.dart
russellwheatley Jun 25, 2024
b63b420
Update js_interop.dart
russellwheatley Jun 25, 2024
03b8a06
Merge branch 'firebase:master' into fix-web-build-error
elitree Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/_flutterfire_internals/lib/_flutterfire_internals.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import 'package:firebase_core/firebase_core.dart';
import 'src/interop_shimmer.dart'
if (dart.library.js_interop) 'package:firebase_core_web/firebase_core_web_interop.dart'
as core_interop;
import 'src/interop_shimmer.dart' if (dart.library.js_interop) 'dart:js_interop'
as js_interop;
import 'src/interop_shimmer.dart'
if (dart.library.js_interop) 'src/js_interop.dart' as js_interop;

export 'src/exception.dart';

Expand Down
6 changes: 6 additions & 0 deletions packages/_flutterfire_internals/lib/src/js_interop.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// Copyright 2024, the Chromium project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

/// This is a stub file to work around odd dart web compiler builder issues.
export 'dart:js_interop';