Skip to content

Conversation

@Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Jan 23, 2023

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

closes #10311

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone marked this pull request as ready for review February 14, 2023 08:27
@Lyokone Lyokone marked this pull request as draft February 14, 2023 08:29
Copy link
Member

@Ehesp Ehesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lyokone Lyokone marked this pull request as ready for review February 14, 2023 09:14
@Lyokone
Copy link
Contributor Author

Lyokone commented Feb 14, 2023

@kevinthecheung I've added some documentation on Trusted Types. Let me know if you think this documentation should be placed somewhere else.

@Lyokone
Copy link
Contributor Author

Lyokone commented Feb 16, 2023

I'll merge it for release, let me know if I should open another PR for moving the documentation.

@Lyokone Lyokone merged commit da74aab into master Feb 16, 2023
@Lyokone Lyokone deleted the fix/10311 branch February 16, 2023 12:39
@adar2378
Copy link

adar2378 commented Feb 16, 2023

Guys is this something related? Started to happen after 2.6 update I Think
#10474

@firebase firebase locked and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [firebase_core_web] TrustedType violations

4 participants