Skip to content

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Fixes from C++ SDK reflected in Unity SDK.


Testing

Describe how you've tested these changes.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@jonsimantov jonsimantov enabled auto-merge (squash) July 11, 2022 18:01
@jonsimantov jonsimantov merged commit 3f0af59 into main Jul 11, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jul 11, 2022
@github-actions
Copy link

github-actions bot commented Jul 11, 2022

❌  Integration test FAILED

Requested by @firebase-workflow-trigger[bot] on commit 2a1f9e7
Last updated: Mon Jul 11 17:22 PDT 2022
View integration test log & download artifacts

Failures Configs
analytics [TEST] [ERROR] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
firestore [BUILD] [ERROR] [2019] [macos] [1/3 Platform(s): Android]
functions [TEST] [ERROR] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
installations [TEST] [ERROR] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
messaging [TEST] [ERROR] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): ios_target]
[TEST] [FAILURE] [2019] [macos] [1/5 Platform(s): iOS] [1/3 Test Device(s): simulator_target]
storage [TEST] [FAILURE] [2019] [macos] [4/5 Platform(s): windows iOS ubuntu macos] [1/3 Test Device(s): simulator_target]
[TEST] [FLAKINESS] [2019] [macos] [2/5 Platform(s): Android iOS] [All 2 FTL Devices]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 11, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 12, 2022
@firebase firebase locked and limited conversation to collaborators Aug 11, 2022
@a-maurice a-maurice deleted the js-readme-changes-920 branch May 8, 2024 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants