Skip to content

Conversation

a-maurice
Copy link
Collaborator

@a-maurice a-maurice commented Jun 10, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

The C++ repo recently changed the ndk version to 21e, so update the Unity repo to use the same.


Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/2466239666


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from DellaBitta June 10, 2022 17:54
Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a CI check on the build for this?

@a-maurice
Copy link
Collaborator Author

Is there a CI check on the build for this?

Yeah, I had run https://github.com/firebase/firebase-unity-sdk/actions/runs/2466239666 from this branch earlier, but before I made the PR, so it didn't get picked up.

@a-maurice a-maurice merged commit c596d72 into main Jun 10, 2022
@a-maurice a-maurice deleted the am-ndk_version branch June 10, 2022 18:03
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 10, 2022
@github-actions
Copy link

github-actions bot commented Jun 10, 2022

❌  Integration test FAILED

Requested by @a-maurice on commit c596d72
Last updated: Fri Jun 10 18:05 PDT 2022
View integration test log & download artifacts

Failures Configs
analytics [BUILD] [ERROR] [2019] [macos] [All 2 Platform(s)]
[TEST] [ERROR] [2019] [macos] [1/5 Platform(s): Playmode]
firestore [TEST] [FLAKINESS] [2019] [macos] [1/5 Platform(s): iOS] [ios_target]
functions [BUILD] [ERROR] [2019] [macos] [All 2 Platform(s)]
[TEST] [ERROR] [2019] [macos] [1/5 Platform(s): Playmode]
messaging [TEST] [ERROR] [2019] [macos] [1/5 Platform(s): iOS] [ios_target]
remote_config [TEST] [FLAKINESS] [2019] [macos] [1/5 Platform(s): iOS] [ios_target]
storage [BUILD] [ERROR] [2019] [macos] [All 2 Platform(s)]
[TEST] [ERROR] [2019] [macos] [1/5 Platform(s): Playmode]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jun 10, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 11, 2022
@firebase firebase locked and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants