Don't swallow emulator hub when version differs

[fredzqm]

I ran into this a couple of times. "Cannot contact the Emulator Hub" is very confusing and hard to debug.

The root cause is my CLI build and emulator build are using slight different version. Started from VS Code or local installation.

I'd expect many customers to run into this given the proliferation of npx firebase-tools in MCP tools and VS Code.

[gemini-code-assist]

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines how the emulator hub processes its locator file, ensuring that the system can always retrieve the necessary connection information, even when minor version discrepancies exist. This change aims to improve the robustness and startup reliability of the emulator by preventing it from discarding valid locator data due to version differences.

Highlights

• Emulator Hub Locator Handling: The logic for handling the emulator hub locator file has been updated. Previously, if the locator's version did not match the CLI's version (and it wasn't a VSCode extension), the locator would be discarded. Now, the locator is always returned, regardless of version mismatch or whether it's a VSCode extension. A debug log will still indicate a version mismatch, but it will no longer prevent the locator from being used.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request changes the behavior of the emulator hub to no longer ignore locator files with a different version. This is a good change to improve compatibility between different CLI versions. I have a suggestion to make this more robust. The debug log message is now misleading as it says 'ignoring' when the locator is in fact being used. Also, instead of just a debug log for any version mismatch, it would be better to use semver to check for major version differences and issue a warning, as this could prevent hard-to-debug issues with incompatible APIs.

[fredzqm]

@tammam-g I believe that you also ran into this bug when working on MCP tool to local emulator.

Let me know if you think this will improve its stability

[yuchenshi]

CHANGELOG please

[fredzqm]

CHANGELOG please

For sure~