Skip to content

Bump FDC local toolkit to v1.8.0. #8210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,8 @@
- Fixed SSR issues in Angular 19 by adding support for default and reqHandler exports. (#8145)
- Added Angular 19 as supported version. (#8145)
- Fixed `appdistribution:testers:list` raising an error when a tester is not part of any group. (#8191)
- Updated the Firebase Data Connect local toolkit to v1.8.0, which includes several changes: (#8210)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Updated the Firebase Data Connect local toolkit to v1.8.0, which includes several changes: (#8210)
- Updated the Firebase Data Connect local toolkit to v1.8.0, which: (#8210)

- Adds support for the `v1` Data Connect API in the emulator
- Adds support for generated React SDKs
- Fixes `@check` to also be evaluated for admin auth
- Fixes CEL expressions to be able to access `@redact` fields
18 changes: 9 additions & 9 deletions src/emulator/downloadableEmulators.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const lsofi = require("lsofi");

Check warning on line 1 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe assignment of an `any` value

Check warning on line 1 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Require statement not part of import statement
import {
Emulators,
DownloadableEmulators,
Expand Down Expand Up @@ -59,20 +59,20 @@
dataconnect:
process.platform === "darwin"
? {
version: "1.7.7",
expectedSize: 25359104,
expectedChecksum: "c5481addc04e14d10538add7aabda183",
version: "1.8.0",
expectedSize: 25469696,
expectedChecksum: "d20a4240b4290a262caff3d0d3a85a4f",
}
: process.platform === "win32"
? {
version: "1.7.7",
expectedSize: 25788416,
expectedChecksum: "9f7e5b9bcbca47de509fbc26cc1e0fa8",
version: "1.8.0",
expectedSize: 25903616,
expectedChecksum: "dda0350259449493ecc5cc24187ce752",
}
: {
version: "1.7.7",
expectedSize: 25268376,
expectedChecksum: "fb239ecf5dcbf87b762d12a3e9dee012",
version: "1.8.0",
expectedSize: 25383064,
expectedChecksum: "54a19e336f4118854c4c2d4eeeccb506",
},
};

Expand Down Expand Up @@ -274,7 +274,7 @@
shell: false,
},
pubsub: {
binary: `${getExecPath(Emulators.PUBSUB)!}`,

Check warning on line 277 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Forbidden non-null assertion
args: [],
optionalArgs: ["port", "host"],
joinArgs: true,
Expand Down Expand Up @@ -310,7 +310,7 @@
}

/**
* @param name

Check warning on line 313 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Missing JSDoc @param "name" description
*/
export function getLogFileName(name: string): string {
return `${name}-debug.log`;
Expand All @@ -323,7 +323,7 @@
*/
export function _getCommand(
emulator: DownloadableEmulators,
args: { [s: string]: any },

Check warning on line 326 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unexpected any. Specify a different type
): DownloadableEmulatorCommand {
const baseCmd = Commands[emulator];
const defaultPort = Constants.getDefaultPort(emulator);
Expand All @@ -336,7 +336,7 @@
if (
baseCmd.binary === "java" &&
utils.isRunningInWSL() &&
(!args.host || !args.host.includes(":"))

Check warning on line 339 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe member access .includes on an `any` value

Check warning on line 339 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe call of an `any` typed value
) {
// HACK(https://github.com/firebase/firebase-tools-ui/issues/332): Force
// Java to use IPv4 sockets in WSL (unless IPv6 address explicitly used).
Expand All @@ -355,7 +355,7 @@
}

const argKey = "--" + key;
const argVal = args[key];

Check warning on line 358 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe assignment of an `any` value

if (argVal === undefined) {
logger.log("DEBUG", `Ignoring empty arg for key: ${key}`);
Expand All @@ -364,9 +364,9 @@

// Sigh ... RTDB emulator needs "--arg val" and PubSub emulator needs "--arg=val"
if (baseCmd.joinArgs) {
cmdLineArgs.push(`${argKey}=${argVal}`);

Check warning on line 367 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Invalid type "any" of template literal expression
} else {
cmdLineArgs.push(argKey, argVal);

Check warning on line 369 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe argument of type `any` assigned to a parameter of type `string`
}
});

Expand Down
Loading