Skip to content

Add handling for REQUIRE_FORCE issues. #8151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 10, 2025
Merged

Add handling for REQUIRE_FORCE issues. #8151

merged 11 commits into from
Feb 10, 2025

Conversation

rosalyntan
Copy link
Member

@rosalyntan rosalyntan commented Jan 29, 2025

Description

Add handling for the REQUIRE_FORCE warning level. If fdc build returns an issue with REQUIRE_FORCE, the --force flag is required in order to deploy that change. Also includes a minor fix for parsing the Workaround object.

Scenarios Tested

  • firebase deploy --force with an operation missing an @auth directive
  • firebase deploy with an operation missing an @auth directive

Sample Commands

firebase deploy
Screenshot 2025-01-30 at 2 56 47 PM

@rosalyntan rosalyntan changed the title Add handling for REQUIRE_FORCE issues. Add handling for REQUIRE_FORCE issues. Jan 30, 2025
@rosalyntan rosalyntan marked this pull request as ready for review January 30, 2025 22:52
@rosalyntan rosalyntan requested a review from joehan January 30, 2025 22:53
joehan
joehan previously requested changes Feb 4, 2025
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the cli-table3 issue

@rosalyntan rosalyntan requested a review from joehan February 4, 2025 00:42
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.14%. Comparing base (c0226eb) to head (b95b23f).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/dataconnect/graphqlError.ts 33.33% 2 Missing ⚠️
src/dataconnect/build.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8151      +/-   ##
==========================================
+ Coverage   51.12%   51.14%   +0.02%     
==========================================
  Files         423      423              
  Lines       29722    29729       +7     
  Branches     6083     6085       +2     
==========================================
+ Hits        15196    15206      +10     
+ Misses      13160    13157       -3     
  Partials     1366     1366              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosalyntan rosalyntan enabled auto-merge (squash) February 7, 2025 00:14
@rosalyntan rosalyntan dismissed joehan’s stale review February 7, 2025 00:45

Changes addressed

@rosalyntan rosalyntan merged commit 2bfb61b into master Feb 10, 2025
51 of 56 checks passed
@rosalyntan rosalyntan deleted the rosalyntan.linter branch February 10, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants