Skip to content

Conversation

bkendall
Copy link
Contributor

@bkendall bkendall commented Nov 13, 2024

Description

Updates superstatic to v9.1.0.

Fixes #7929
Fixes #7173

Scenarios Tested

A basic website still worked well with this version. Works on node 22 as well!

@bkendall bkendall requested a review from joehan November 13, 2024 17:45
@bkendall bkendall enabled auto-merge (squash) November 13, 2024 21:12
@bkendall bkendall merged commit 6153607 into master Nov 13, 2024
44 of 45 checks passed
@f0urfingeredfish
Copy link
Contributor

f0urfingeredfish commented Nov 20, 2024

@bkendall looks like you forgot to commit the changes to the package.json and it's still on the old version of superstatic https://github.com/firebase/firebase-tools/blob/master/package.json#L155

I just upgraded to firebase-tools": "^13.26.0 and It's still pulling in the old version of "superstatic": "^9.0.3"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix vulnerable package path-to-regex of superstatic firebase serve: TypeError: Cannot read properties of undefined (reading 'getTime')
3 participants