Skip to content

Conversation

@Ferido07
Copy link
Contributor

Fixes #6382

Due to braking changes on the signature of loadConfig (https://github.com/vercel/next.js/blob/d96e0258de2caf34e9322d0d32ab5748533c4465/packages/next/src/server/config.ts#L784) Firebase does not deploy correctly.

Description

Scenarios Tested

Sample Commands

@google-cla
Copy link

google-cla bot commented Sep 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.70%. Comparing base (67f7480) to head (b513b29).
⚠️ Report is 1384 commits behind head on master.

Files with missing lines Patch % Lines
src/frameworks/next/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6383   +/-   ##
=======================================
  Coverage   54.69%   54.70%           
=======================================
  Files         346      346           
  Lines       23670    23670           
  Branches     4870     4870           
=======================================
+ Hits        12946    12948    +2     
+ Misses       9531     9529    -2     
  Partials     1193     1193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firebase tools doesn't deploy NextJs web framework for NextJs >=13.5.0

4 participants