Adding Docker image build to release script #6255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #6255 +/- ##
=======================================
Coverage 54.58% 54.58%
=======================================
Files 346 346
Lines 23717 23717
Branches 4875 4875
=======================================
Hits 12946 12946
Misses 9586 9586
Partials 1185 1185 ☔ View full report in Codecov by Sentry. |
mbleigh
reviewed
Aug 15, 2023
scripts/publish.sh
Outdated
| echo "Pushed to GitHub." | ||
|
|
||
| echo "Publishing Docker image..." | ||
|
|
There was a problem hiding this comment.
Derp - should have cleaned this up, was a remnant of a different approach
mbleigh
reviewed
Aug 15, 2023
scripts/publish/cloudbuild.yaml
Outdated
| ] | ||
|
|
||
| images: | ||
| - "gcr.io/$PROJECT_ID/firebase" |
There was a problem hiding this comment.
Maybe firebase-cli or firebase-tools?
|
Should probably store things in Artifact Registry instead of GCR even on a temporary basis since GCR is not recommended for new things. |
bkendall
requested changes
Aug 15, 2023
|
Cleaned this up, and switched to publishing the images to AR on firebase-cli instead of GCR on fir-tools-builds |
|
Happy 2024! @joehan, is there a guesstimate when you think this will get to the finish line? |
bkendall
approved these changes
Apr 16, 2025
blidd-google
pushed a commit
that referenced
this pull request
May 12, 2025
* Adding Docker image build to publish script * formats * starting on PR fixes * Switching to AR on firebase-cli instead of GCR on fir-tools-builds * Updating to include latest emulators * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #6094 - adding a step to the release script to build a Docker image of the latest firebase-tools version on each release.
Right now, this stores the image in Artifact Registry on the firebase-cli project I'm not sure that this is ultimately where we want it to live, so I'm going to reach out to OSPO folks about other options.
Scenarios Tested
Using the scripts/publish/firebase-docker-image/run.sh on a test project, I successfully built images with the correct tags.