-
Notifications
You must be signed in to change notification settings - Fork 1.1k
refactor: migrate from cli-color to colorette #4818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bkendall there are 6 type errors left. all around strip and move. |
|
I've rebased to include latest commits from |
|
True to my word I think I have the last 5%. I'm going to run this through a couple paces and somehow get the commit to you |
|
I think what you can do is this. Fetch the references in firebase/firebase-tools, and then cherry-pick this commit:
If that doesn't work, I'll make a new PR from the |
|
Used the GitHub UI to sync the fork 👍 it actually works pretty well when there are no conflicts |
|
Could you do one last thing: add a small entry to - Replaces underlying terminal coloring library. |
Codecov Report
@@ Coverage Diff @@
## master #4818 +/- ##
==========================================
- Coverage 57.75% 57.73% -0.02%
==========================================
Files 287 287
Lines 18733 18734 +1
Branches 3695 3699 +4
==========================================
- Hits 10819 10816 -3
- Misses 7028 7032 +4
Partials 886 886
Continue to review full report at Codecov.
|
|
done |
Description
migrate codebase from
cli-colortocolorettefixes #4793