Skip to content

Conversation

@AviVahl
Copy link

@AviVahl AviVahl commented Aug 2, 2022

Description

migrate codebase from cli-color to colorette
fixes #4793

@AviVahl
Copy link
Author

AviVahl commented Aug 2, 2022

@bkendall there are 6 type errors left. all around strip and move.

@AviVahl
Copy link
Author

AviVahl commented Aug 2, 2022

I've rebased to include latest commits from master

@bkendall
Copy link
Contributor

bkendall commented Aug 2, 2022

True to my word I think I have the last 5%. I'm going to run this through a couple paces and somehow get the commit to you

@bkendall
Copy link
Contributor

bkendall commented Aug 2, 2022

I think what you can do is this. Fetch the references in firebase/firebase-tools, and then cherry-pick this commit:

git cherry-pick 4f957f49b

If that doesn't work, I'll make a new PR from the cli-color-to-colorette which includes both commits.

@AviVahl
Copy link
Author

AviVahl commented Aug 2, 2022

Used the GitHub UI to sync the fork 👍 it actually works pretty well when there are no conflicts

@AviVahl AviVahl marked this pull request as ready for review August 2, 2022 23:57
@bkendall
Copy link
Contributor

bkendall commented Aug 2, 2022

Could you do one last thing: add a small entry to CHANGELOG.md that reads something like

- Replaces underlying terminal coloring library.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #4818 (e8f8b1e) into master (7064e48) will decrease coverage by 0.01%.
The diff coverage is 80.17%.

@@            Coverage Diff             @@
##           master    #4818      +/-   ##
==========================================
- Coverage   57.75%   57.73%   -0.02%     
==========================================
  Files         287      287              
  Lines       18733    18734       +1     
  Branches     3695     3699       +4     
==========================================
- Hits        10819    10816       -3     
- Misses       7028     7032       +4     
  Partials      886      886              
Impacted Files Coverage Δ
src/deploy/hosting/deploy.ts 16.36% <25.00%> (-1.82%) ⬇️
src/auth.ts 22.71% <33.33%> (-0.27%) ⬇️
src/extensions/updateHelper.ts 77.01% <33.33%> (-1.82%) ⬇️
src/deploy/database/prepare.ts 25.00% <50.00%> (ø)
src/deploy/database/release.ts 30.76% <50.00%> (ø)
src/deploy/extensions/tasks.ts 18.64% <50.00%> (ø)
src/deploy/hosting/uploader.ts 12.90% <50.00%> (ø)
src/deploy/hosting/validate.ts 66.66% <50.00%> (-2.57%) ⬇️
src/deploy/index.ts 30.00% <50.00%> (ø)
src/emulator/extensionsEmulator.ts 29.92% <50.00%> (ø)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7064e48...e8f8b1e. Read the comment docs.

@AviVahl
Copy link
Author

AviVahl commented Aug 3, 2022

done

@bkendall bkendall merged commit 3970dda into firebase:master Aug 3, 2022
@AviVahl AviVahl deleted the cli-color-to-colorette branch August 3, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

firebase-tools depends es5-ext (via cli-color), which prints messages when in Russia

3 participants