Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@
- Fixes some Storage Emulator UI errors.
- Fixes some issues when using Emulator UI on a different device.
- Fixes issues where functions:log command did not showing some log entries. (#3539)
- Fixes Emulator issue when function definition changes (#2533).
19 changes: 17 additions & 2 deletions src/emulator/functionsEmulator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -432,9 +432,24 @@ export class FunctionsEmulator implements EmulatorInstance {
}

// We want to add a trigger if we don't already have an enabled trigger
// with the same entryPoint.
// with the same entryPoint / trigger.
const anyEnabledMatch = Object.values(this.triggers).some((record) => {
return record.def.entryPoint === definition.entryPoint && record.enabled;
const sameEntryPoint = record.def.entryPoint === definition.entryPoint;

// If they both have event triggers, make sure they match
const sameEventTrigger =
JSON.stringify(record.def.eventTrigger) === JSON.stringify(definition.eventTrigger);

if (sameEntryPoint && !sameEventTrigger) {
this.logger.log(
"DEBUG",
`Definition for trigger ${definition.entryPoint} changed from ${JSON.stringify(
record.def.eventTrigger
)} to ${JSON.stringify(definition.eventTrigger)}`
);
}

return record.enabled && sameEntryPoint && sameEventTrigger;
});
return !anyEnabledMatch;
});
Expand Down