Skip to content

Conversation

@anishkny
Copy link
Contributor

@anishkny anishkny commented Jul 4, 2021

Description

Emulator does not log about the default being used for any other option. Why log about default used for sourceDirectory? Seems unnecessary.

Scenarios Tested

Tested locally.

Sample Commands

N/A

Emulator does not log about the default being used for any other option. Why log about default used for `sourceDirectory`? Seems unnecessary.
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Jul 4, 2021
@samtstern samtstern requested a review from joehan July 5, 2021 08:02
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@joehan joehan merged commit bc1bd07 into firebase:master Jul 7, 2021
@anishkny anishkny deleted the patch-2 branch July 7, 2021 16:45
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
Emulator does not log about the default being used for any other option. Why log about default used for `sourceDirectory`? Seems unnecessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants