Skip to content

Add missing changelog entry for #3499 #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Add missing changelog entry for #3499 #3500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
584106b
Add changelog for #3499
huangjeff5 Jun 16, 2021
02c1730
Fix lint
huangjeff5 Jun 16, 2021
b7dbe81
use active voice in changelog
huangjeff5 Jun 16, 2021
f678eb4
Fix lint
huangjeff5 Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fixes an issue with ext:update where local extension is incorrectly inferred as published (#3499)
8 changes: 8 additions & 0 deletions src/test/extensions/updateHelper.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,38 +599,44 @@ describe("getExistingSourceOrigin", () => {
isOfficialStub = sinon.stub(resolveSource, "isOfficialSource");
isOfficialStub.returns(true);
getInstanceStub = sinon.stub(extensionsApi, "getInstance").resolves(INSTANCE);

const result = await updateHelper.getExistingSourceOrigin(
"invader-zim",
"instance-of-official-ext",
"ext-testing",
"projects/firebasemods/sources/fake-official-source"
);

expect(result).to.equal(extensionsHelper.SourceOrigin.OFFICIAL_EXTENSION);
});

it("should return published extension as source origin", async () => {
registryEntryStub = sinon.stub(resolveSource, "resolveRegistryEntry");
registryEntryStub.throwsException("Entry not found");
getInstanceStub = sinon.stub(extensionsApi, "getInstance").resolves(REGISTRY_INSTANCE);

const result = await updateHelper.getExistingSourceOrigin(
"invader-zim",
"instance-of-registry-ext",
"ext-testing",
"projects/firebasemods/sources/fake-registry-source"
);

expect(result).to.equal(extensionsHelper.SourceOrigin.PUBLISHED_EXTENSION);
});

it("should return local extension as source origin", async () => {
registryEntryStub = sinon.stub(resolveSource, "resolveRegistryEntry");
registryEntryStub.throwsException("Entry not found");
getInstanceStub = sinon.stub(extensionsApi, "getInstance").resolves(LOCAL_INSTANCE);

const result = await updateHelper.getExistingSourceOrigin(
"invader-zim",
"instance-of-local-ext",
"ext-testing",
"projects/firebasemods/sources/fake-local-source"
);

expect(result).to.equal(extensionsHelper.SourceOrigin.LOCAL);
});

Expand All @@ -640,12 +646,14 @@ describe("getExistingSourceOrigin", () => {
isOfficialStub = sinon.stub(resolveSource, "isOfficialSource");
isOfficialStub.returns(false);
getInstanceStub = sinon.stub(extensionsApi, "getInstance").resolves(LOCAL_INSTANCE);

const result = await updateHelper.getExistingSourceOrigin(
"invader-zim",
"instance-of-local-ext",
"ext-testing",
"projects/firebasemods/sources/fake-local-source"
);

expect(result).to.equal(extensionsHelper.SourceOrigin.LOCAL);
});
});