Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/extensions/extensionsHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export enum SpecParamType {
SELECT = "select",
MULTISELECT = "multiSelect",
STRING = "string",
SELECTRESOURCE = "selectResource",
}

export enum SourceOrigin {
Expand Down Expand Up @@ -302,6 +303,15 @@ export function validateSpec(spec: any) {
}
}
}
if (param.type && param.type == SpecParamType.SELECTRESOURCE) {
if (!param.resourceType) {
errors.push(
`Param${param.param ? ` ${param.param}` : ""} must have resourceType because it is type ${
param.type
}`
);
}
}
}
if (errors.length) {
const formatted = errors.map((error) => ` - ${error}`);
Expand Down
20 changes: 20 additions & 0 deletions src/test/extensions/extensionsHelper.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,26 @@ describe("extensionsHelper", () => {
extensionsHelper.validateSpec(testSpec);
}).to.throw(FirebaseError, /default/);
});
it("should error if a param selectResource missing resourceType.", () => {
const testSpec = {
version: "0.1.0",
specVersion: "v1beta",
params: [
{
type: extensionsHelper.SpecParamType.SELECTRESOURCE,
validationRegex: "test",
default: "fail",
},
],
resources: [],
sourceUrl: "https://test-source.fake",
license: "apache-2.0",
};

expect(() => {
extensionsHelper.validateSpec(testSpec);
}).to.throw(FirebaseError, /must have resourceType/);
});
});

describe("promptForValidInstanceId", () => {
Expand Down