Skip to content

Fix nextPageToken edge case in batchGet. #3253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2021
Merged

Fix nextPageToken edge case in batchGet. #3253

merged 1 commit into from
Apr 2, 2021

Conversation

@yuchenshi
Copy link
Member

@yuchenshi yuchenshi commented Apr 1, 2021

Fixes #3231

@yuchenshi yuchenshi requested a review from sam-gc April 1, 2021 23:07
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Apr 1, 2021
@yuchenshi yuchenshi merged commit 6644790 into master Apr 2, 2021
@yuchenshi yuchenshi deleted the ys/nextPageToken branch April 2, 2021 16:20
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this pull request Dec 14, 2021
@yuchenshi @devpeerapong
Fix nextPageToken edge case in batchGet. (firebase#3253)
290970c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sam-gc sam-gc sam-gc approved these changes

Assignees

@sam-gc sam-gc

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Auth Emulator batchGet should return nextPageToken if page is full

2 participants

@yuchenshi @sam-gc