Skip to content

Debounce kill signals #2517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2020
Merged

Debounce kill signals #2517

merged 1 commit into from
Aug 4, 2020

Conversation

@samtstern
Copy link
Contributor

@samtstern samtstern commented Aug 3, 2020

Description

This fixes #2507 (which is npm's fault not ours) by debouncing kill signals.

Scenarios Tested

Was able to successfully --export-on-exit from a npm script.

Sample Commands

N/A

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Aug 3, 2020
@samtstern samtstern requested a review from yuchenshi August 3, 2020 10:43
@samtstern samtstern merged commit 9133f6c into master Aug 4, 2020
@yuchenshi yuchenshi mentioned this pull request Aug 4, 2020
Closed
This was referenced Jan 14, 2021
Closed
Closed
@bkendall bkendall deleted the ss-fix-2507 branch August 4, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

Assignees

No one assigned

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No graceful exit using NPM Scripts

3 participants

@samtstern @yuchenshi @googlebot