Hosting deploy wrongly assumes all-or-none webframeworks

[fivecar]

Environment info

firebase-tools:
13.30.0

Platform:
Ubuntu

Test case

1. Create a firebase.json with two hosting targets: one using webframeworks and one normal (i.e. "target: framey" with source and "target: classic" with public).
2. Attempt firebase deploy --only hosting:classic

Steps to reproduce

(same as test case above)

Expected behavior

Deploy of "classic" target to succeed. Of course a deploy of hosting:framey should fail... but I wouldn't expect classic to fail because it doesn't use webframeworks.

Actual behavior

Deployment errors out with "Cannot deploy a web framework from source because the experiment webframeworks is not enabled. To enable webframeworks run firebase experiments:enable webframeworks."

I suspect this line is the problem. The tools shouldn't be asserting webframeworks whenever any target requires it... it should only be asserting it for the specific target if it uses it.

[aalej]

Thanks for the detailed report and for submitting a PR @fivecar! I’m able to reproduce the error you mentioned. I do think that this behavior can be improved by only asserting webframeworks to be enabled if the target requires it(uses hosting.source).

Let me ask someone from our engineering team to take a look into this.

[fivecar]

@aalej : I've already attached a PR that fixes it (#8169). So this only needs the eng team to approve the PR.