Skip to content

Readme update for testing. #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Readme update for testing. #930

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5866ba4
Readme update for testing.
christhompsongoogle Mar 21, 2023
f2938b9
More changes
christhompsongoogle Mar 21, 2023
45993e3
Merge branch 'master' into readmeUpdate
christhompsongoogle Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,17 @@ See the section about [running tests](https://facebook.github.io/create-react-ap
To run the test runner with emulators, use:

```bash
firebase emulators:exec --project sample --only firestore 'npm test'
Copy link
Member

@yuchenshi yuchenshi Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Collaborator Author

@christhompsongoogle christhompsongoogle Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, missed this one: basically as an easier copy/paster since we have the --only demonstrated below

firebase emulators:exec --project sample 'npm test'

firebase emulators:exec --project sample --only firestore 'npm test AddCollectionDialog.test.tsx'
```

To disable the Jest interactive mode use the flag `watchAll=false` like so:

```bash
firebase emulators:exec --project sample --only firestore 'npm test -- --watchAll=false'
```

If you get port conflict errors, make sure to stop other instances of the Firebase Emulator Suite (e.g. the one you've started for the development server above) and try again.

#### `npm run build`
Expand Down