Adding SDK-created extensions support #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Added extension instance id in the list Changed message for non-SDK-created extensions New message for SDK-created extensions Message no longer specific to non-SDK-created extensions (now includes both) |
tjlav5
reviewed
Oct 2, 2024
| <div className={styles.learnButton}> | ||
| <a | ||
| href={DOCS_BASE + docSuffix} | ||
| target="_blank" |
Contributor
There was a problem hiding this comment.
You can use the ExternalLink component here, also why a tab-index of -1?
Contributor
Author
There was a problem hiding this comment.
discussed offline. This is ok.
| rel="noopener noreferrer" | ||
| tabIndex={-1} | ||
| > | ||
| <Button>Learn more</Button> |
Contributor
There was a problem hiding this comment.
Hmm I don't think we should have buttons inside of anchors... that's not valid HTML
Contributor
Author
There was a problem hiding this comment.
Discussed offline. This is ok.
tjlav5
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding SDK-created extensions support