Skip to content

Look before leaping #8292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Look before leaping #8292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08a173d
Look before leaping
jsoref May 30, 2024
c769aba
Look before leaping
jsoref May 30, 2024
27f830e
Look before leaping
jsoref May 30, 2024
f74376c
Look before leaping
jsoref May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 58 additions & 2 deletions .github/workflows/canary-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,60 @@ jobs:
run: yarn
- name: Deploy canary
run: yarn release canary
if: ${{
env.NPM_TOKEN_ANALYTICS != '' &&
env.NPM_TOKEN_ANALYTICS_INTEROP_TYPES != '' &&
env.NPM_TOKEN_ANALYTICS_TYPES != '' &&
env.NPM_TOKEN_APP != '' &&
env.NPM_TOKEN_APP_TYPES != '' &&
env.NPM_TOKEN_APP_CHECK != '' &&
env.NPM_TOKEN_APP_CHECK_INTEROP_TYPES != '' &&
env.NPM_TOKEN_APP_CHECK_TYPES != '' &&
env.NPM_TOKEN_AUTH != '' &&
env.NPM_TOKEN_AUTH_INTEROP_TYPES != '' &&
env.NPM_TOKEN_AUTH_TYPES != '' &&
env.NPM_TOKEN_COMPONENT != '' &&
env.NPM_TOKEN_DATABASE != '' &&
env.NPM_TOKEN_DATABASE_TYPES != '' &&
env.NPM_TOKEN_FIRESTORE != '' &&
env.NPM_TOKEN_FIRESTORE_TYPES != '' &&
env.NPM_TOKEN_FUNCTIONS != '' &&
env.NPM_TOKEN_FUNCTIONS_TYPES != '' &&
env.NPM_TOKEN_INSTALLATIONS != '' &&
env.NPM_TOKEN_INSTALLATIONS_TYPES != '' &&
env.NPM_TOKEN_LOGGER != '' &&
env.NPM_TOKEN_MESSAGING != '' &&
env.NPM_TOKEN_MESSAGING_TYPES != '' &&
env.NPM_TOKEN_PERFORMANCE != '' &&
env.NPM_TOKEN_PERFORMANCE_TYPES != '' &&
env.NPM_TOKEN_POLYFILL != '' &&
env.NPM_TOKEN_REMOTE_CONFIG != '' &&
env.NPM_TOKEN_REMOTE_CONFIG_TYPES != '' &&
env.NPM_TOKEN_RULES_UNIT_TESTING != '' &&
env.NPM_TOKEN_STORAGE != '' &&
env.NPM_TOKEN_STORAGE_TYPES != '' &&
env.NPM_TOKEN_TESTING != '' &&
env.NPM_TOKEN_UTIL != '' &&
env.NPM_TOKEN_VERTEXAI != '' &&
env.NPM_TOKEN_VERTEXAI_PREVIEW != '' &&
env.NPM_TOKEN_WEBCHANNEL_WRAPPER != '' &&
env.NPM_TOKEN_FIREBASE != '' &&
env.NPM_TOKEN_APP_COMPAT != '' &&
env.NPM_TOKEN_INSTALLATIONS_COMPAT != '' &&
env.NPM_TOKEN_ANALYTICS_COMPAT != '' &&
env.NPM_TOKEN_AUTH_COMPAT != '' &&
env.NPM_TOKEN_MESSAGING_INTEROP_TYPES != '' &&
env.NPM_TOKEN_FUNCTIONS_COMPAT != '' &&
env.NPM_TOKEN_MESSAGING_COMPAT != '' &&
env.NPM_TOKEN_PERFORMANCE_COMPAT != '' &&
env.NPM_TOKEN_REMOTE_CONFIG_COMPAT != '' &&
env.NPM_TOKEN_DATABASE_COMPAT != '' &&
env.NPM_TOKEN_FIRESTORE_COMPAT != '' &&
env.NPM_TOKEN_STORAGE_COMPAT != '' &&
env.NPM_TOKEN_APP_CHECK_COMPAT != '' &&
env.NPM_TOKEN_API_DOCUMENTER != '' &&
true
}}
env:
NPM_TOKEN_ANALYTICS: ${{secrets.NPM_TOKEN_ANALYTICS}}
NPM_TOKEN_ANALYTICS_INTEROP_TYPES: ${{secrets.NPM_TOKEN_ANALYTICS_INTEROP_TYPES}}
Expand Down Expand Up @@ -94,13 +148,15 @@ jobs:
CI: true
- name: Launch E2E tests workflow
# Trigger e2e-test.yml
env:
OSS_BOT_GITHUB_TOKEN: ${{ secrets.OSS_BOT_GITHUB_TOKEN }}
if: env.OSS_BOT_GITHUB_TOKEN != ''
run: |
VERSION_SCRIPT="const pkg = require('./packages/firebase/package.json'); console.log(pkg.version);"
VERSION_OR_TAG=`node -e "${VERSION_SCRIPT}"`
OSS_BOT_GITHUB_TOKEN=${{ secrets.OSS_BOT_GITHUB_TOKEN }}
curl -X POST \
-H "Content-Type:application/json" \
-H "Accept:application/vnd.github.v3+json" \
-H "Authorization:Bearer $OSS_BOT_GITHUB_TOKEN" \
-d "{\"event_type\":\"canary-tests\", \"client_payload\":{\"versionOrTag\":\"$VERSION_OR_TAG\"}}" \
https://api.github.com/repos/firebase/firebase-js-sdk/dispatches
https://api.github.com/repos/firebase/firebase-js-sdk/dispatches
54 changes: 54 additions & 0 deletions .github/workflows/prerelease-manual-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,60 @@ jobs:
run: yarn
- name: Deploy prerelease
run: yarn release custom -p ${{ github.event.inputs.prereleaseName }} -t ${{ github.event.inputs.npmTag }}
if: ${{
env.NPM_TOKEN_ANALYTICS != '' &&
env.NPM_TOKEN_ANALYTICS_INTEROP_TYPES != '' &&
env.NPM_TOKEN_ANALYTICS_TYPES != '' &&
env.NPM_TOKEN_APP != '' &&
env.NPM_TOKEN_APP_TYPES != '' &&
env.NPM_TOKEN_APP_CHECK != '' &&
env.NPM_TOKEN_APP_CHECK_INTEROP_TYPES != '' &&
env.NPM_TOKEN_APP_CHECK_TYPES != '' &&
env.NPM_TOKEN_AUTH != '' &&
env.NPM_TOKEN_AUTH_INTEROP_TYPES != '' &&
env.NPM_TOKEN_AUTH_TYPES != '' &&
env.NPM_TOKEN_COMPONENT != '' &&
env.NPM_TOKEN_DATABASE != '' &&
env.NPM_TOKEN_DATABASE_TYPES != '' &&
env.NPM_TOKEN_FIRESTORE != '' &&
env.NPM_TOKEN_FIRESTORE_TYPES != '' &&
env.NPM_TOKEN_FUNCTIONS != '' &&
env.NPM_TOKEN_FUNCTIONS_TYPES != '' &&
env.NPM_TOKEN_INSTALLATIONS != '' &&
env.NPM_TOKEN_INSTALLATIONS_TYPES != '' &&
env.NPM_TOKEN_LOGGER != '' &&
env.NPM_TOKEN_MESSAGING != '' &&
env.NPM_TOKEN_MESSAGING_TYPES != '' &&
env.NPM_TOKEN_PERFORMANCE != '' &&
env.NPM_TOKEN_PERFORMANCE_TYPES != '' &&
env.NPM_TOKEN_POLYFILL != '' &&
env.NPM_TOKEN_REMOTE_CONFIG != '' &&
env.NPM_TOKEN_REMOTE_CONFIG_TYPES != '' &&
env.NPM_TOKEN_RULES_UNIT_TESTING != '' &&
env.NPM_TOKEN_STORAGE != '' &&
env.NPM_TOKEN_STORAGE_TYPES != '' &&
env.NPM_TOKEN_TESTING != '' &&
env.NPM_TOKEN_UTIL != '' &&
env.NPM_TOKEN_VERTEXAI != '' &&
env.NPM_TOKEN_VERTEXAI_PREVIEW != '' &&
env.NPM_TOKEN_WEBCHANNEL_WRAPPER != '' &&
env.NPM_TOKEN_FIREBASE != '' &&
env.NPM_TOKEN_APP_COMPAT != '' &&
env.NPM_TOKEN_INSTALLATIONS_COMPAT != '' &&
env.NPM_TOKEN_ANALYTICS_COMPAT != '' &&
env.NPM_TOKEN_AUTH_COMPAT != '' &&
env.NPM_TOKEN_MESSAGING_INTEROP_TYPES != '' &&
env.NPM_TOKEN_FUNCTIONS_COMPAT != '' &&
env.NPM_TOKEN_MESSAGING_COMPAT != '' &&
env.NPM_TOKEN_PERFORMANCE_COMPAT != '' &&
env.NPM_TOKEN_REMOTE_CONFIG_COMPAT != '' &&
env.NPM_TOKEN_DATABASE_COMPAT != '' &&
env.NPM_TOKEN_FIRESTORE_COMPAT != '' &&
env.NPM_TOKEN_STORAGE_COMPAT != '' &&
env.NPM_TOKEN_APP_CHECK_COMPAT != '' &&
env.NPM_TOKEN_API_DOCUMENTER != '' &&
true
}}
env:
NPM_TOKEN_ANALYTICS: ${{secrets.NPM_TOKEN_ANALYTICS}}
NPM_TOKEN_ANALYTICS_INTEROP_TYPES: ${{secrets.NPM_TOKEN_ANALYTICS_INTEROP_TYPES}}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release-log.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
node-version: 20.x

- name: Get PR number and send to tracker.
if: env.RELEASE_TRACKER_URL != ''
run: node scripts/ci/log-changesets.js
env:
RELEASE_TRACKER_URL: ${{ secrets.RELEASE_TRACKER_URL }}
1 change: 1 addition & 0 deletions .github/workflows/release-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,6 @@ jobs:

- name: Create Release Pull Request
uses: changesets/action@v1
if: env.GITHUB_TOKEN != ''
env:
GITHUB_TOKEN: ${{ secrets.OSS_BOT_GITHUB_TOKEN }}