Skip to content

Remove part of the mergeField comment #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2018
Merged

Remove part of the mergeField comment #822

merged 3 commits into from
May 15, 2018

Conversation

@schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented May 15, 2018 •
edited
Loading

mikelehen
mikelehen approved these changes May 15, 2018
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jshcrowthe
jshcrowthe approved these changes May 15, 2018
View reviewed changes
Copy link
Contributor

@jshcrowthe jshcrowthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@schmidt-sebastian schmidt-sebastian merged commit dd11cd1 into master May 15, 2018
@schmidt-sebastian schmidt-sebastian deleted the schmidt-sebastian-patch-2 branch May 16, 2018 21:08
@firebase firebase locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wilhuff wilhuff Awaiting requested review from wilhuff

2 more reviewers

@mikelehen mikelehen mikelehen approved these changes

@jshcrowthe jshcrowthe jshcrowthe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikelehen mikelehen

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@schmidt-sebastian @mikelehen @jshcrowthe @google-oss-bot