Skip to content

Conversation

@mmermerkaya
Copy link
Contributor

Tests are the same as Messaging's type-check test.

This should prevent issues like #787.

@mmermerkaya mmermerkaya force-pushed the mmermerkaya-types-tests branch from e0bac79 to 521820d Compare May 8, 2018 19:13
Copy link
Contributor

@jshcrowthe jshcrowthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jshcrowthe jshcrowthe merged commit 8922c3a into master May 8, 2018
@jshcrowthe jshcrowthe deleted the mmermerkaya-types-tests branch May 8, 2018 19:48
@firebase firebase locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants